search

carlin-q-scott / browser-media-keys

Lets you control many web players using the media keys on your keyboard.
Mozilla Public License 2.0
123 stars 31 forks source link

stopped working with the new Pandora website #118

Closed caente closed 7 years ago

caente commented 7 years ago

After pandora updated its website the media keys stopped working -- on pandora, everything else works fine.

I've tested it on mac and fedora 25

carlin-q-scott commented 7 years ago

Already fixed but I haven't pushed the release out yet.

caente commented 7 years ago

awesome! thanks

On Thu, Feb 16, 2017 at 1:10 AM Carlin Scott notifications@github.com wrote:

Already fixed but I haven't pushed the release out yet.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/carlin-q-scott/browser-media-keys/issues/118#issuecomment-280240746, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrB2TUpqqZDXIIx0xqZ3pXfqXv87Ilzks5rc-hMgaJpZM4L-hlC .

ksariash commented 7 years ago

workaround.zip

EDIT: I revived an old addon as a workaround for now. It'll add a button which will play/pause pandora. You can also use it with ctrl+alt+p, or firefox.exe -pandoraplaypause. Install by renaming the .zip to .xpi

EDIT2: The workaround is super buggy so I would only recommend it if you're desperate. It was a super old addon I had written and I didnt change anything other than update the play/pause javascript.

fix should be something along the lines of... MediaKeys.playButton = "//div[@class='PlayButton' and contains(@data-qa,'pause_button')]"; MediaKeys.pauseButton = "//div[@class='PlayButton' and contains(@data-qa,'play_button')]";

carlin-q-scott commented 7 years ago

This is fixed btw.