carlin-q-scott / browser-media-keys

Lets you control many web players using the media keys on your keyboard.
Mozilla Public License 2.0
123 stars 31 forks source link

Add pocketcasts #133

Closed sleepypikachu closed 7 years ago

carlin-q-scott commented 7 years ago

This looks fine but you need to add pocketcasts to pageMods.json.

sleepypikachu commented 7 years ago

Thanks, I've pushed that change.

Do you have plans to re-write this using the new web extensions API?

carlin-q-scott commented 7 years ago

Yes, I have forked the project as browser-media-players and already have it working with Opera/Chrome using the browser support for media keys. Firefox doesn't currently support media keys in Web Extensions and getting access to OS APIs to support them is totally different and more challenging than with the Firefox SDK; so that'll take a while I think.

If you have any expertise in Web Extensions I'd appreciate some help as I haven't ported over the media tab pinning feature or add-on preferences yet.