search

carlin-q-scott / browser-media-keys

Lets you control many web players using the media keys on your keyboard.
Mozilla Public License 2.0
123 stars 31 forks source link

Media keys not working out of browser #159

Closed MaddoScientisto closed 5 years ago

MaddoScientisto commented 5 years ago

OS: windows 10 Pro 1803 Browser: firefox quantum 62.0.3 Keyboard: CM storm XT When I make use of the media keys they seem to only work when the browser window is focused, I don't have any other application that is making use of the media keys, tested on youtube

gmelikov commented 5 years ago

@MaddoScientisto this is a limitation of Firefox quantum, see v.2.0 description:

Due to the conversion, some features have been removed or modified:
1. The browser window must be active for media keys to be detected.
2. Only Play/Pause is supported; this is a Firefox limitation.
2. Pinned tabs get priority over all other tabs when pressing a media key.
3. The autoplay feature is disabled by default and cannot be enabled until I create a configuration page for the add-on.

@carlin-q-scott maybe we need to show this text in addon description, so people can see it?

MaddoScientisto commented 5 years ago

@MaddoScientisto this is a limitation of Firefox quantum, see v.2.0 description:

Due to the conversion, some features have been removed or modified:
1. The browser window must be active for media keys to be detected.
2. Only Play/Pause is supported; this is a Firefox limitation.
2. Pinned tabs get priority over all other tabs when pressing a media key.
3. The autoplay feature is disabled by default and cannot be enabled until I create a configuration page for the add-on.

@carlin-q-scott maybe we need to show this text in addon description, so people can see it?

it's funny because I came here because the addon description on the site specifically said to let you know

gmelikov commented 5 years ago

@carlin-q-scott https://addons.mozilla.org/en-US/firefox/addon/media-keys/?src=search I think we should fix this text:

Your media keys should work without the Firefox window active for Linux (w/ Gnome) and Windows but please let us know if this isn't the case by providing us with the version of your operating system, and model of keyboard or laptop you're using.

carlin-q-scott commented 5 years ago

@gmelikov thanks for catching that. I guess I only updated the Readme in the forked repo. I've updated the add-on description.

carlin-q-scott commented 5 years ago

@MaddoScientisto Sorry for the confusion. If you'd like the global support back then I suggest downgrading to version 1 and disabling automatic update for the extension. Alternatively, vote for https://bugzilla.mozilla.org/show_bug.cgi?id=1411795