search

carlin-q-scott / browser-media-players

Control interface for a variety of web based media players
Mozilla Public License 2.0
58 stars 8 forks source link

Conflict with other "function keys" #11

Open ve3 opened 5 years ago

ve3 commented 5 years ago

I have a Logitect keyboard "MK235" like this one. When I'm playing YouTube and open the calculator from keyboard the YT video stopped.

To re-product bug:

  1. Open YouTube or any website that is using YouTube embedded.
  2. Play the video.
  3. Press fn+F4 (F4 for my keyboard is calculator sign).
  4. The Windows calculator openned. YouTube stopped playing.
ghost commented 5 years ago

@carlin-q-scott any update on this? It seems all of my "extra" keys trigger the MediaPlayPause

carlin-q-scott commented 5 years ago

This is a browser bug. I spent some time looking through the Firefox source and I now know what is causing the issue, but I do not know how to solve it yet.

The issue is that they are using key codes to map keys to add-on commands, but all of the extended keys on a keyboard don't have key codes. There are other properties for the keys that they can use to map the keys, but there's a lot of places to make that same change.

hyvyys commented 4 years ago

I'm having this issue too: when I change screen brightness (Fn+ArrowUp/ArrowDown on my laptop keyboard), Youtube starts/stops.

eduard-sukharev commented 3 years ago

On Lenovo ThinkBook the Fn key itself alone triggers play-pause. Provided that my keyboard doesn't have dedicated home/end/pgup/pgdown keys and those are bound to Fn+arrows I kept triggering music any time I tried to navigate any other page. I'm glad I've found the culprit extension and can now disable it. The extension itself is fine, but the bug breaks all my UX.