Create a method to chart Expert+ double bass drum

[GoogleCodeExporter]

Many of the people that create drum charts with double bass pedal post their 
chart with two MIDIs, one with double bass and one without.  The single bass 
MIDI is usually kept as notes.mid, while the double bass may be named various 
things (such as notesexpert+.mid).

In order to make it easier to package such charts, it would be convenient if 
EOF provided a fifth difficulty for PART DRUMS.  If this difficulty is 
populated during save, EOF could default to creating a MIDI to contain it, 
naming it notesexpert+.mid if the user community agrees that's the most common 
name for it.  This MIDI file would otherwise be identical to notes.mid, only 
that the Expert drum track is replaced with the Expert+ drum track.

Potentially, it can be a user-configured name for what the expert+ MIDI gets 
named during save.

Original issue reported on code.google.com by raynebc on 31 Aug 2010 at 10:49

[GoogleCodeExporter]

As posted here:
http://www.fretsonfire.net/forums/viewtopic.php?f=4&t=49417&p=556720#p556719

RawkSD (a Wii homebrew for loading content from SD card as usable in-game 
content in Rock Band 2) uses a custom notation of note 95 as the double bass 
that would be hidden except for when the Expert+ difficulty was selected.

If FoFiX or Phase Shift implement this, then the Expert+ difficulty tab can be 
skipped and a drum lane can be added for the double bass notation (when Expert 
difficulty is displayed).

Original comment by raynebc on 3 Oct 2010 at 10:31

[GoogleCodeExporter]

thekiwimaddog indicated that Phase Shift is going to adopt this notation as 
double bass to be offered in the "Expert+" drum track difficulty.  I have a 
couple of ideas for offering the ability to chart this:

1. Have users select the bass drum notes in the Expert difficulty and use a 
menu option (or equivalent keyboard input to trigger such an option) to mark 
selected bass notes as Expert+.

2. Have users use a specific key to place Expert+ bass notes (such as the ` key 
or the 6 key).  This favors people that are used to the Rex Mundi input mode, 
but it's not unprecedented, as vocal percussion notes are placed with 
Backspace, regardless of the input mode in effect.

3. Create an additional drum lane to represent the Expert+ bass notes.

The first two options will require much less effort than option 3, but all of 
them will probably require implementing a new difficulty bit flag.  Since the 
forced HOPO on/off and "crazy" statuses don't apply to drum notes, any of those 
flag bits can be recycled for double bass drum.

The Expert+ bass notes could be rendered the same as regular bass drum, except 
the bar could be red instead of green.  This may require a recolored bass drum 
graphic for the 3D preview.  During export, any Expert bass drum notes with the 
double bass status flag will be written as note 95.

Original comment by raynebc on 5 Oct 2010 at 7:18

• Changed title: Create a method to chart Expert+ double bass drum

[GoogleCodeExporter]

r438 begins this logic with a means to mark such notes.  These notes will be 
saved with MIDI note 95 and should work in Phase Shift when Expert+ is 
implemented in the game.

It should be relatively easy to implement some FoFiX specific logic so that 
during save, if any such notes exist, a notesexpert+.mid file is created to 
contain the Expert+ drum track and potentially all other instruments and their 
difficulties as well.

Original comment by raynebc on 5 Oct 2010 at 10:22

• Changed state: Started

[GoogleCodeExporter]

Phase Shift 0.71 implements this Expert+ bass drum notation.  Since there is no 
good way to guess if and when FoFiX will implement this solution, it may still 
be a good idea to allow EOF to create a second MIDI file to contain Expert+ 
drums.  wolferacing indicated that the name "expert+.mid" should be sufficient 
for naming the secondary MIDI file.

The remaining tasks for this issue are:

1.  Provide a recolored bass drum 3D graphic
2.  Alter EOF's MIDI export to create a second MIDI.  A good way to implement 
this may be to have EOF generate the MIDI event data for PART DRUMS if normal, 
and then if any Expert bass drum notes had the Expert+ notation, those could be 
added to the MIDI event list with eof_add_midi_event(), the list could be quick 
sorted, and another file to hold the Expert+ MIDI track could be written.  
After notes.mid was created, the tempo map followed by the Expert+ track data 
could be written to expert+.mid.

Original comment by raynebc on 6 Oct 2010 at 10:50

[GoogleCodeExporter]

Task 1 was implemented in r441.  It was much easier than I thought, since the 
bass drum notes are just being rendered as a polygon.

Original comment by raynebc on 6 Oct 2010 at 11:20

[GoogleCodeExporter]

Task 2 was implemented in r442, which completes this enhancement.

Original comment by raynebc on 7 Oct 2010 at 6:02

• Changed state: Fixed