carlito913 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Update EOF project file format #185

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There will eventually need to be changes to the project format in order to 
support MIDI timing, pro guitar tracks, keys, additional tracks, etc.

It will be easiest for changes to be proposed by the "EOF proposed project 
format.txt" document that was uploaded in r484.  To begin with, there will be 
some redundancy in that the proposed format allows both millisecond and MIDI 
timings to be stored, allowing for a code transition from one timing system to 
another.  When millis are no longer used, they can be removed in the next 
format draft.

Original issue reported on code.google.com by raynebc on 20 Oct 2010 at 12:46

GoogleCodeExporter commented 8 years ago
My recommendation would be to make the change soon after the 1.7 release, as 
the current project format is the main bottleneck in implementing many future 
changes, especially "pro mode" charting.  The save/load code would be the only 
thing that changes immediately, then the new features could be implemented at 
any time since they would already be accommodated for in the project file 
format.

Original comment by raynebc on 3 Nov 2010 at 10:03

GoogleCodeExporter commented 8 years ago

Original comment by raynebc on 18 Nov 2010 at 9:51

GoogleCodeExporter commented 8 years ago
r572 starts this.  The current revision of the chart format ('F') is now loaded 
in the legacy project loading code.  Before the save logic is updated, I 
figured the load logic should be completed and reviewed first.

Everything up to the track loading code has been put in place, but we may want 
to make more progress on issue 205 first, as how charts are maintained while 
the application is running will affect how they are saved/loaded/etc.  Once EOF 
stores tracks in a fashion that's more compatible with how they will be stored 
to file in the new format, it should be easy to finish this enhancement.

Original comment by raynebc on 18 Nov 2010 at 11:53

GoogleCodeExporter commented 8 years ago

Original comment by raynebc on 18 Nov 2010 at 11:54

GoogleCodeExporter commented 8 years ago
Since the save and load formats no longer match, the Undo function is presently 
broken.

Original comment by raynebc on 19 Nov 2010 at 3:41

GoogleCodeExporter commented 8 years ago
I restored the original load function a while ago to restore functionality to 
Undo.  I will wait until the save and load logic is finished (at least for 
legacy and vocal tracks) and then switch them both at the same time.

Original comment by raynebc on 21 Nov 2010 at 7:28

GoogleCodeExporter commented 8 years ago
r587 completes the new chart loading logic.  Once the chart save logic is 
completed and working along with the load logic, I'll work on the other export 
and import code.

Original comment by raynebc on 23 Nov 2010 at 6:14

GoogleCodeExporter commented 8 years ago
r589 puts the new save and load logic into use.  Normal saving and loading 
appears to work, but undo seems broken.

Original comment by raynebc on 25 Nov 2010 at 1:11

GoogleCodeExporter commented 8 years ago
By now, the new save and load logic are working, as is undo/redo.  Work on this 
will continue as new chart formats are supported, and the logic to save/load 
them is programmed.  Before this issue is closed, the revision 'H' EOF project 
file format description could probably benefit from some more cleaning up.

Original comment by raynebc on 2 Dec 2010 at 6:35

GoogleCodeExporter commented 8 years ago
I don't foresee any need for further changes to the project format, but will 
leave this open until the next stable release of EOF, at which point this 
revision will be considered implemented.

Original comment by raynebc on 9 Jan 2011 at 10:14

GoogleCodeExporter commented 8 years ago
Several revisions ago, the pro guitar note bitmask was changed from 16 bits to 
8 bits to allow a ghost bitmask to be stored for each note.  Ghost notes were 
the only remaining note playing mechanic that I'm aware of (required for 
arpeggio chords) that wasn't originally accounted for in the updated EOF 
project file spec.

Original comment by raynebc on 26 Jan 2011 at 10:56

GoogleCodeExporter commented 8 years ago

Original comment by raynebc on 22 Mar 2011 at 12:25

GoogleCodeExporter commented 8 years ago
I don't see a reason for this enhancement to remain open, the file 
specification document will remain updated.

Original comment by raynebc on 27 Jun 2012 at 8:29