Improve rendering of phrases in editor window

[GoogleCodeExporter]

Solo phrases are obvious because the entire fretboard background is blue, 
however star power and cymbal phrases are not.  A note has to be placed within 
the phrase before it is rendered as being within the phrase.  An improvement 
would be to add coloring for SP and the 3 pro drum phrases.

For a star power phrase, the fretboard space between the first (from the 
bottom) and second fret lanes could be rendered in silver.

For a yellow cymbal phrase, the fretboard space between the second and third 
fret lanes could be rendered in yellow.

For a blue cymbal phrase, the fretboard space between the third and fourth fret 
lanes could be rendered in blue.

For a green cymbal phrase, the fretboard space between the fourth and fifth 
fret lanes could be rendered in green.

Since notes are placed on the lines instead of in between them in the editor 
window, this method will leave the notes easily visible no matter which 
sections are rendered, and it will allow the current solo fretboard visual 
markers to be visible.  Eventually, we may want to change note 5 from purple to 
green and the bass drum color to orange.  This will reduce confusion between 
the different colorings between EOF and Rock Band, since the pro drum markers 
are color specific.  Alternatively, we could change the wording of the crash 
cymbal marker to reflect the color purple instead of green.

Original issue reported on code.google.com by raynebc on 24 Nov 2010 at 6:15

[GoogleCodeExporter]

For an arpeggio phrase, the fretboard space between the fifth and sixth fret 
lanes (since these only exist in pro guitar charts) could be rendered in light 
green.

Original comment by raynebc on 27 Dec 2010 at 9:54

[GoogleCodeExporter]

r651 adds rendering in the sixth lane for arpeggio sections.  This should 
easily work for the other phrase types given above.

This enhancement will necessitate the creation of actual phrases for pro drum 
markers, but the current behavior of marking all notes within the phrase 
(regardless of difficulty) as cymbals should be kept.

Original comment by raynebc on 28 Dec 2010 at 12:35

• Changed state: Started

[GoogleCodeExporter]

eof_determine_phrase_status() could be modified to update the pro drum statuses 
of notes that fall within pro drum markers.  This would make the markers 
operate identically to star power, solo, trill, tremolo and arpeggio markers.  
Once the markers are available, it will make fretboard coloring for the phrases 
easy to accomplish.

Original comment by raynebc on 9 Jan 2011 at 10:33

[GoogleCodeExporter]

r696 adds logic to render SP phrases at the top of the fretboard area and 
guarantees that solo phrases are visible at the bottom of the fretboard area 
(even when all lanes have trill or tremolo phrases rendered).  The only things 
left to finish are as follows:

1. Implement phrases for each of the three pro drum markers.  They will each 
require one status flag, and eof_determine_phrase_status() would need to be 
updated to set/clear those statuses appropriately.  The original cymbal status 
flags should be re-usable for this purpose.  Since previous releases of EOF 
stored cymbals as note statuses logic will need to be run after import to 
generate the pro drum phrases based on these statuses (all adjacent cymbals are 
marked with single phrases).  This same logic can be used to ensure the phrases 
are correct before exporting the MIDI.
2. Migrate away from the original pro drum system that emulated phrase markers 
and remove that obsolete logic.
3. eof_mark_edited_note_as_cymbal() may require a replacement so that newly 
added notes are automatically made into cymbals.  This would probably require 
adding logic to see if the previous or next note is within a pro drum phrase, 
and if so, remark that phrase to include the new note.  It might be better to 
scrap this "new notes are cymbals" feature altogether.

Original comment by raynebc on 26 Jan 2011 at 10:24

[GoogleCodeExporter]

I'm finding that the dark blue used for solo markers can be difficult to see if 
all other lanes worth of fretboard background are consumed with tremolo or 
trill markers, so it may be worth lightening the color a little bit.

Original comment by raynebc on 8 Feb 2011 at 8:38

[GoogleCodeExporter]

r821 brightened the blue color used for solo marker rendering.

Original comment by raynebc on 16 Sep 2011 at 8:34

[GoogleCodeExporter]

At this point, I don't see a benefit to implementing tom phrases, considering 
how much easier it is to mark cymbals as EOF currently does it.  Forcing the 
user to manage one phrase type for each tom color would make it much more 
complicated.

Original comment by raynebc on 24 Oct 2011 at 10:04

• Changed state: Done