Closed GoogleCodeExporter closed 8 years ago
Original comment by raynebc
on 6 Dec 2010 at 11:34
In r610, the changes broke the highlighting of the note at the current fret
catalog playback position during fret catalog playback. I couldn't determine
why this was so, but the benefit of removing hundreds of lines of code is more
immediately important.
Original comment by raynebc
on 6 Dec 2010 at 11:36
r611 likewise broke the highlighting of the lyric at the current fret catalog
playback position during fret catalog playback. The trade-off, however, was
the removal of a couple hundred more lines of rendering code. I imagine the
fix has something to do with querying the catalog playback position instead of
the chart position, but I haven't tracked it down yet.
Original comment by raynebc
on 7 Dec 2010 at 9:07
Also, the lyric at the current playback position or mouse over position doesn't
render over other lyrics that are close enough to cut off part of the text (in
the lyric lane).
Original comment by raynebc
on 29 Dec 2010 at 7:06
Original comment by raynebc
on 16 Sep 2011 at 11:31
r832 fixes lyric highlighting during chart playback. The issue was that the
hover lyric wasn't being read in the common editor logic. The other issues are
probably that the appropriate logic isn't being run to find the hover note and
lyric during fret catalog playback.
I'm still not sure why the lyric in the current hover position isn't rendering
on top of other lyrics that are close enough to cut off its text.
Original comment by raynebc
on 25 Sep 2011 at 1:38
The issue where lyrics/notes don't highlight during fret catalog playback is
probably because the hover note and lyric are not being looked for. The logic
to look for each could probably be moved to a common function that is called
during playback in general, regardless of whether it's the chart or the fret
catalog being played.
Original comment by raynebc
on 25 Sep 2011 at 1:54
r848 fixes issues with the hover key/note/lyric during fret catalog playback.
I'm not going to worry about the hover lyric still being truncated in the
editor window at this time, as the user can just zoom in or view the full lyric
in the lyric preview.
Original comment by raynebc
on 13 Nov 2011 at 7:39
Original issue reported on code.google.com by
raynebc
on 5 Dec 2010 at 9:10