carlito913 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Add a "Test in Phase Shift" function #239

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
thekiwimaddog implemented some initial command line support for Phase Shift to 
launch into the a menu for a song passed as an argument:

http://www.fretsonfire.net/forums/viewtopic.php?f=28&t=46312&p=578944#p578945

The indicated syntax is as follows:
(Phase Shift executable path) (Chart path) /p

If the "/p" argument is left out, the chart starts is launched for quickplay 
mode instead of practice mode.  Much of the existing "Test in FoF" logic can be 
shared with this feature.

Original issue reported on code.google.com by raynebc on 19 Feb 2011 at 12:33

GoogleCodeExporter commented 8 years ago
Some tasks for this enhancement:

1.  Create a "Link to Phase Shift" menu function that queries for the path of 
the Phase Shift executable and song folder, which will be stored in variables 
the same way that eof_fof_songs_path and eof_fof_executable_path currently are.
2.  Modify eof_menu_song_test() to take a parameter and launch either Phase 
Shift or FoF based on that parameter.
3.  Modify the eof_song_menu[] dialog to call a function 
(eof_menu_song_test_fof) to call eof_menu_song_test(), since dialog menu 
functions cannot have parameters.  Add a menu item for "Test in Phase Shift", 
ensuring that EOF_LINUX_DISABLE is used to conditionally disable the menu item 
if the platform isn't Windows.
4.  Update the documentation.

Original comment by raynebc on 20 Feb 2011 at 7:15

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
r708 completes tasks 1, 2 and 3.  This does need to be tested, but provided 
that it works, all that is left is to update the documentation.

Original comment by raynebc on 24 Feb 2011 at 12:32

GoogleCodeExporter commented 8 years ago
r709 adjusts the command line, but it still doesn't seem to be working for some 
reason.

Original comment by raynebc on 24 Feb 2011 at 3:39

GoogleCodeExporter commented 8 years ago
At this point, I'm convinced that there is a limitation in the method EOF uses 
to launch the executable.  The debug logic exports the command that is 
launched, and it looks perfectly fine, but the command doesn't seem to launch 
Phase Shift.

Original comment by raynebc on 28 Feb 2011 at 6:39

GoogleCodeExporter commented 8 years ago
NewCreature wasn't immediately sure why it isn't working either.  It may be 
best to just write a batch file that is launched.  The "Test in Phase Shift" 
debug text file output I'm currently creating can just be altered to write to a 
.bat file and launched with eof_system() instead.

Original comment by raynebc on 3 Mar 2011 at 8:38

GoogleCodeExporter commented 8 years ago
r717 gets the feature working in Phase Shift.  All that's left is to update the 
documentation.

Original comment by raynebc on 4 Mar 2011 at 3:44

GoogleCodeExporter commented 8 years ago
r718 updates the documentation.

Original comment by raynebc on 4 Mar 2011 at 6:57