search

carlito913 / editor-on-fire

Automatically exported from code.google.com/p/editor-on-fire
Other
0 stars 0 forks source link

Hang during Feedback import #245

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
As mentioned here:
http://www.fretsonfire.net/forums/viewtopic.php?f=6&t=50992&start=165#p582106

gunder sent me the chart files, and I was able to confirm a hang in 
eof_init_after_load() -> eof_calculate_beats() when importing 
Notes_Typhus_fixed.chart.

In eof_calculate_beats(), beat_length was set to 0, and the for loop runs 
forever.

Original issue reported on code.google.com by raynebc on 18 Mar 2011 at 12:54

GoogleCodeExporter commented 8 years ago 
eof_import_chart was setting the ppqn value of the last beat to 0 because this 
chart's last anchor event was TS change (which is stored as a structure with a 
tempo of 0).  This caused the floating point equation in eof_calculate_beats() 
to fail, setting beat_length to a value of 0.  Thus the loop in 
eof_calculate_beats() would run forever or until the program crashed.

Original comment by raynebc on 20 Mar 2011 at 1:49

GoogleCodeExporter commented 8 years ago 
Fixed in r725.

Original comment by raynebc on 20 Mar 2011 at 1:52