search

carlitoplatanito / gulp-nunjucks-render

[Gulp](https://github.com/wearefractal/gulp) plugin to render [Nunjucks](http://mozilla.github.io/nunjucks/) templates
149 stars 33 forks source link

Update for nunjucks 3.0.0 #54

Closed stephan-gh closed 7 years ago

stephan-gh commented 7 years ago

nunjucks 3.0.0 was released, any chance you can update this plugin to make it use the new version? Thanks!

stephan-gh commented 7 years ago

I'm closing this since @mohitsinghs https://github.com/mohitsinghs/gulp-nunjucks-md can be used for an updated version of gulp-nunjucks-render. It works fine for rendering regular HTML pages.

kamlekar commented 7 years ago

Why this isn't being updated?

stephan-gh commented 7 years ago

@kamlekar I don't know, it seems like @carlosl is no longer maintaining it.

mohitsinghs commented 7 years ago

@Minecrell @carlosl is back. See #56 and also I tried explaining the differences between this plugin and my plugin in with an example.

stephan-gh commented 7 years ago

@mohitsinghs Oh, in this case I'll reopen this issue. Since you have updated nunjucks in your plugin and the old, regular HTML page rendering is still working, is there anything that would speak against merging your changes into gulp-nunjucks-render?

mohitsinghs commented 7 years ago

@Minecrell

is there anything that would speak against merging your changes into gulp-nunjucks-render ?

Yes, The way I used markdown and front-matter. I don't think everyone will prefer my way, so why not have two options. Anyway everything which works with this plugin should work fine with my plugin. I just don't wanted to add two or more extra plugins ( gulp-data and gulp-front-matter ) and a hacky function to achieve what I wanted and hence I created that plugin. You can consider my plugin as some cool extra functions added to this plugin which should be avoided for simple uses. You can see #55 for what I wanted. I hope you got your answer. Thanks.

kevinmpowell commented 7 years ago

I've added a PR to update to nunjucks 3.0.0

https://github.com/carlosl/gulp-nunjucks-render/pull/58

revelt commented 7 years ago

@carlosl please consider adding more people to maintainers list, people are using this library and can help