search

carljm / django-form-utils

[UNMAINTAINED] Form enhancements for Django (fieldset and row-attrs support, and more)
BSD 3-Clause "New" or "Revised" License
145 stars 52 forks source link

Version 1.0 is not compatible with Django 1.4 #7

Closed sandino closed 10 years ago

sandino commented 10 years ago

Hi,

Dependencies for 1.0 version need to be changed to point to Django 1.5, as it throws error in forms.py.

cannot import name python_2_unicode_compatible

The python_2_unicode_compatible decorator appeared only in Django 1.5

carljm commented 10 years ago

python_2_unicode_compatible (along with the rest of the Py2/3 support code, e.g. django.utils.six) was actually backported to 1.4 in a bugfix release, precisely for this reason - to assist third-party code in becoming Python 3 compatible without having to drop support for 1.4 or bundle these utilities. They first appeared in 1.4.2; latest version of 1.4 is 1.4.6. You must be using an older version, either 1.4.0 or 1.4.1. I highly recommend upgrading to the latest; several of those bugfix releases were also security releases.

ocZio commented 10 years ago

Hi,

I think the following is related (not directly to 1.4) but the current Django trunk version.

https://github.com/django/django/commit/589dc49e129f63801c54c15e408c944a345b3dfe

It seems that django-form-utils is broken with the latest Django :-)

carljm commented 10 years ago

Thanks for pointing that out, fixed in aff5cbc697db8