carllerche / syncbox

Concurrency utilities for Rust
131 stars 14 forks source link

Use wait_timeout instead of wait_timeout_ms #38

Closed laanwj closed 8 years ago

laanwj commented 8 years ago

wait_timeout_ms is deprecated, and causes an error when building with rust nightly. Replace it with wait_timeout which takes a std::time::Duration.

carllerche commented 8 years ago

Thanks for the PR (sorry for being sooo late).

I would like to keep my libs running on Rust 1.3. I believe that this change would break that :( Unfortunately, I don't know of a great way to handle API changes & deprecation warnings.

laanwj commented 8 years ago

I understand, I'm new to rust so I wouldn't know for sure. The API churn can be quite annoying but that's life with a young language I guess.