search

carllerche / tower-web

A fast, boilerplate free, web framework for Rust
MIT License
981 stars 51 forks source link

Improve error handling #171

Closed manifest closed 5 years ago

manifest commented 5 years ago

The PR for the issue.

manifest commented 5 years ago

Tests fail on Clippy checks that doesn't relate to this commit.

carllerche commented 5 years ago

Error is due to handlebars updating to pest 2.0. I filed an issue, but odds are it won't be fixed.

carllerche commented 5 years ago

I merged master, which should hopefully fix CI.

carllerche commented 5 years ago

@manifest It looks like there are some real errors :(

manifest commented 5 years ago

@carllerche fixed

nightly build still fails because of

The command "curl -sSf https://sh.rustup.rs | sh -s -- --default-toolchain=$TRAVIS_RUST_VERSION -y" failed and exited with 1 during .
carllerche commented 5 years ago

Ok, lets see if #176 fixes it.

carllerche commented 5 years ago

Ok, I merged so lets see.

manifest commented 5 years ago

@carllerche all tests are passed

manifest commented 5 years ago

I've added one more commit removing extract::error::Error::web function since it isn't used anywhere and in order to encourage using of From<error::error::Error>. There were no releases with it public, so it isn't a broken change, right?

manifest commented 5 years ago

There is a binary file that got checked in (src/error/.map.rs.swp).

Fixed

carllerche commented 5 years ago

Thanks, released.