search

carllerche / tower-web

A fast, boilerplate free, web framework for Rust
MIT License
980 stars 51 forks source link

Port tower-web to Edition 2018 #209

Closed elpiel closed 5 years ago

elpiel commented 5 years ago

Since I needed it to work with 2018 edition I've spend 10-15 minutes just porting it and at the end the async/await example also works!

I've just ran the cargo fix --edition and fixed one place where ::Error was left. The rest was just changing the example and the Cargo.toml of the project and the example.

Plus the features futures_api is not necessary any more.

Fixes https://github.com/carllerche/tower-web/issues/192#issuecomment-482449190

lnicola commented 5 years ago

It's fine. By 2015 you mean #[macro_use]? That's all right.

elpiel commented 5 years ago

Ready to go in that case! :tada:

lnicola commented 5 years ago

@carllerche, @shepmaster anything against merging this?

shepmaster commented 5 years ago

Based on my skimming of the changes, it seems fine.

lnicola commented 5 years ago

Based on the tentative positive review of @shepmaster I'll merge this :sweat_smile:.

Thanks, @elpiel.