carlmontanari / scrapli

Fast, flexible, sync/async, Python 3.7+ screen scraping client specifically for network devices

https://carlmontanari.github.io/scrapli/

MIT License

575 stars 59 forks source link

Completely replace pkg_resources with importlib.resources #311

Closed mattmess1221 closed 8 months ago

mattmess1221 commented 8 months ago

Description

Resolves #307

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

All tests in pytest succeed

Checklist:

[x] My code follows the style guidelines of this project (no GitHub actions complaints! run make lint before committing!)
[x] I have commented my code, pydocstyle and darglint are happy, docstrings are in google docstring format, and all docstrings include a summary, args, returns and raises fields (even if N/A)
[x] I have added tests that prove my fix is effective or that my feature works, if adding "functional" tests please note if there are any considerations for the vrnetlab setup
[x] New and existing unit tests pass locally with my changes

codecov[bot] commented 8 months ago

Files	Patch %	Lines
scrapli/helper.py	50.00%	2 Missing :warning:

```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== - Coverage 90.51% 90.50% -0.01% ========================================== Files 60 60 Lines 3488 3487 -1 ========================================== - Hits 3157 3156 -1 Misses 331 331 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carlmontanari commented 8 months ago

🔥 boom! thank you very much @killjoy1221 -- will merge when darlint ci is done (its slooooow, don't think this pr would have any issue there but ya know... just due diligence :))