search

carlobaldassi / ArgParse.jl

Package for parsing command-line arguments to Julia programs.
Other
231 stars 36 forks source link

Rename all mutating functions/macros by appending a `!` #92

Closed carlobaldassi closed 4 years ago

carlobaldassi commented 4 years ago

The most important change is likely @add_arg_table → @add_arg_table!. The others are add_arg_table!, add_arg_group!, set_default_arg_group!, while import_settings! was done in a previous commit. (A major version bump seems like a good opportunity to finally fix this.)

Adds deprecation warnings for the exported ones so that existing codes shouldn't break (at least the tests don't...). A slightly annoying side-effect is that in order to properly deprecate @add_arg_table we must add an explicit dependency on Logging.

There's also a minor change in import_settings! signature.

codecov-io commented 4 years ago

Codecov Report

Merging #92 into master will decrease coverage by 0.39%. The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #92     +/-   ##
=========================================
- Coverage   96.31%   95.92%   -0.4%     
=========================================
  Files           4        5      +1     
  Lines        1195     1201      +6     
=========================================
+ Hits         1151     1152      +1     
- Misses         44       49      +5
Impacted Files Coverage Δ
src/ArgParse.jl 100% <ø> (ø) :arrow_up:
src/deprecated.jl 0% <0%> (ø)
src/parsing.jl 96.91% <100%> (ø) :arrow_up:
src/settings.jl 96.69% <94.73%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 831e07c...bec09b4. Read the comment docs.