carlomanf / wp-super-network

Share content between wordpress sites and create offspring networks.
https://wordpress.org/plugins/wp-super-network/
3 stars 0 forks source link

Revisit permalink transformation #18

Open carlomanf opened 1 year ago

carlomanf commented 1 year ago

Permalinks were originally worked on in https://github.com/carlomanf/wp-super-network/commit/3b38d8cf9bee924e10149eba75a65e3933984b8f and followed up in https://github.com/carlomanf/wp-super-network/commit/015f418106468fd7c8e2aa6a826fc3c6101e819e.

Now that v1.2.0 is going to be taxonomy-aware, a similar approach needs to be taken for taxonomy archive permalinks. Most significantly of all, there is also the attachment source link that needs to be handled in the same way and is currently resulting in broken images.

All of these aspects, and potentially capabilities as well, could be moved out of the Network class and into a new class in a similar way that https://github.com/carlomanf/wp-super-network/commit/2b41bf07742d624d94231f1da32710e0bea94fc8 moved a lot of code out of Network and into a new Query class. The Network class is currently 3–4 times the length of most other classes and is becoming a burden to navigate.