search

carlomanf / wp-super-network

Share content between wordpress sites and create offspring networks.
https://wordpress.org/plugins/wp-super-network/
3 stars 0 forks source link

Unsound implementation of network-based options #8

Closed carlomanf closed 2 years ago

carlomanf commented 2 years ago

If an option is declared as network-based (see #4) and if the value of the option on the main site is false, the re-routing fails and the option is fetched from the local site instead. This is because the pre_option_{$option} filter does not allow false as a return value.

Returning an empty string instead of false might work as a temporary solution, but I expect that in the long term, this could be fixed by handling the whole options feature through the SQL parser.

carlomanf commented 2 years ago

This can be closed as the temporary fix was applied, but the intention is still to rewrite the feature through the SQL parser.