carlonicora / obsidian-rpg-manager

RPG Manager is a tool to simplify the plot, run and track of role playing game campaigns, helping storytellers to run better campaigns in less time.
MIT License
142 stars 13 forks source link

[Bug]: Chapter Wizard not working #344

Open FStriewski opened 2 months ago

FStriewski commented 2 months ago

Check for existing bug reports before submitting.

Expected Behavior

Current behaviour

Capture1

Reproduction

Which Operating Systems are you using?

Obsidian Version Check

1.15.12

Plugin Version

4.1.14

Confirmation

Possible solution

No response

FStriewski commented 2 months ago

Issue with closing the dialog:

Seems like you create the ChapterWizardComponent from CreationComponent (and not from WizardController) and pass undefined to the close function: https://github.com/carlonicora/obsidian-rpg-manager/blob/master/src/components/creation/CreationComponent.tsx#L117

In WizardController the close function is defined.

FStriewski commented 2 months ago

Issue with create:

You can just use campaignPath here, as element is undefined. https://github.com/carlonicora/obsidian-rpg-manager/blob/master/src/components/wizards/chapters/ChapterWizardComponent.tsx#L241

However then there is still an issue with the FileCreationService... I think this needs proper debugging