search

carlopacioni / vortexR

an R package for post Vortex simulation analysis
8 stars 3 forks source link

GGally reverse dependency test check failure #38

Closed schloerke closed 7 years ago

schloerke commented 7 years ago

Hi @carlopacioni,

I'm doing a reverse dependency check before my release and am running into an error.

With some GGally updates, the test at tests/testthat/test-plot.R#L65 is failing. Since the line afterwards is checking if the 'ggmatrix' object exists, I think it is ok to remove this check.

Thank you, Barret

carlopacioni commented 7 years ago

Hi Barret, Done! ...and pushed the changes now. Are you in rush for me to send this to CRAN? I'm almost done with some changes (see branch SSMD_matrix) and should be able to send it off to CRAN in the next couple of days.

carlo

schloerke commented 7 years ago

Hi Carlo,

If you can let me know when you're on CRAN, that would be great!

I was told by Uwe to serve me "two weeks notice" to make changes today. If you're on CRAN before the two weeks are up, awesome!

Thank you for the quick response.

Best, Barret On Sun, Jun 4, 2017 at 9:22 PM carlopacioni notifications@github.com wrote:

Hi Barret, Done! ...and pushed the changes now. Are you in rush for me to send this to CRAN? I'm almost done with some changes (see branch SSMD_matrix) and should be able to send it off to CRAN in the next couple of days.

carlo

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/carlopacioni/vortexR/issues/38#issuecomment-306082011, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFsL5XjmJ8gWwqRpyvHU3-UCOqgtCA7ks5sA1hggaJpZM4Nup_h .

carlopacioni commented 7 years ago

On its way to CRAN now.

cheers, carlo

carlopacioni commented 7 years ago

Hi Barret, All done! The new version of VortexR should be up on cran in the next 24hr. Cheers Carlo

-----Original Message----- From: "Barret Schloerke" notifications@github.com Sent: ‎5/‎06/‎2017 11:30 To: "carlopacioni/vortexR" vortexR@noreply.github.com Cc: "carlopacioni" carlo.pacioni@gmail.com; "Mention" mention@noreply.github.com Subject: Re: [carlopacioni/vortexR] GGally reverse dependency test checkfailure (#38)

Hi Carlo,

If you can let me know when you're on CRAN, that would be great!

I was told by Uwe to serve me "two weeks notice" to make changes today. If you're on CRAN before the two weeks are up, awesome!

Thank you for the quick response.

Best, Barret On Sun, Jun 4, 2017 at 9:22 PM carlopacioni notifications@github.com wrote:

Hi Barret, Done! ...and pushed the changes now. Are you in rush for me to send this to CRAN? I'm almost done with some changes (see branch SSMD_matrix) and should be able to send it off to CRAN in the next couple of days.

carlo

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/carlopacioni/vortexR/issues/38#issuecomment-306082011, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFsL5XjmJ8gWwqRpyvHU3-UCOqgtCA7ks5sA1hggaJpZM4Nup_h .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.