search

carlos-algms / composer-and-node-ci

A docker image with PHP, composer, Node Latest and Yarn installed
https://hub.docker.com/r/carlosalgms/composer-and-node-ci/
MIT License
3 stars 3 forks source link

Deployer 7 #3

Open daiwai opened 2 months ago

daiwai commented 2 months ago

As the current Deployer stable version is v7, it would be nice to have a corresponding image tag. Let me know if you are interested in a PR for Deployer 7 support.

carlos-algms commented 2 months ago

It would be great to have the latest version of Deployer, I personally didn't update it because there are breaking changes and I didn't have time to investigate the required changes in the config.

Also, this image only version PHP and it would be a surprise if someone's pipeline stopped working out of nowhere because docker, K8s, pulled the newest version.

daiwai commented 2 months ago

Thanks Carlos for looking into this.

Totally agreed, that it would be bad to just change the major Deployer version of existing tags, e.g. latest, php8 etc.

I would suggest to introduce a new build target and tag for example php8-deployer-7 so users of existing tags would not be affected.