Avoid passing null to rawurlencode()

carlos-mg89 / PHPoAuthLib

PHP 7 / 8 oAuth 1/2 Client Library

Other

4 stars 7 forks source link

Closed samwilson closed 3 months ago

samwilson commented 3 months ago

Passing null to rawurlencode() is now deprecated, so this coalescese null to the empty string.

Fixes #12

tacman commented 3 months ago

@carlos-mg89 can you approve this PR please, and I'll close #13 .

tacman commented 3 months ago

@samwilson can you make sure this PR works with your library as expected? I don't use it directly, only through phpFlickr. Thx.

samwilson commented 3 months ago

If you fix the conflicts, I'll make sure this one goes live and release a new version of the library.

I've brought this up to date with current master.

I'm not 100% sure that there aren't other similar situations, but I've not hit them in general usage yet to won't add fixes for them yet. :-)

samwilson commented 3 months ago

I think this is ready for review now.

carlos-mg89 commented 3 months ago

I think this is ready for review now.

PR approved and new release launched.

Thanks for helping!