search

carlosantoniodasilva / i18n_alchemy

I18n date/number parsing/localization - RMU Project
http://mendicantuniversity.org/
MIT License
159 stars 34 forks source link

Support for rails 4.2.1 #36

Closed Danielpk closed 9 years ago

Danielpk commented 9 years ago

I trying to update my rails version to 4.2.1 but it looks like i18n_alchemy isnt compatible with rails activesupport =< 4.2.0 is that right?

My Gemfile

gem 'i18n_alchemy', github: 'carlosantoniodasilva/i18n_alchemy', branch: 'master'
gem 'rails', '4.2.1'

What i doing:

$ bundle update rails
Fetching gem metadata from https://rubygems.org/..........
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    i18n_alchemy (>= 0) ruby depends on
      activesupport (<= 4.2.0, >= 3.2.0) ruby

    rails (= 4.2.1) ruby depends on
      activesupport (4.2.1)
carlosantoniodasilva commented 9 years ago

You're correct, we were locking to <= 4.2.0, which does not allow for 4.2.1. I've updated it locally but got some failures with 4.2.1 which I'll have to look at, so it will take a bit of time for the fix to come.

Thanks for reporting! :)

martinsefcik commented 9 years ago

any updates ?

carlosantoniodasilva commented 9 years ago

Sorry, I haven't had a chance to look back at this, if anyone has time it'd be appreciated, otherwise I'll try to do it in the following days/weeks.

Danielpk commented 9 years ago

@carlosantoniodasilva i tried to take a look but i couldnt find any solution. If you have any tip that can help i will try again...

Edit: I tried to fix 3 failure tests:

  1) Failure:
ActionViewTest#test_text_field_with_date_attribute [/Users/danielpk/Code/i18n_alchemy/test/action_view_test.rb:36]:
Expected ["<input id=\"product_released_at\" name=\"product[released_at]\" type=\"text\" value=\"28/02/2011\" />", "<input type=\"text\" value=\"28/02/2011\" name=\"product[released_at]\" id=\"product_released_at\" />"] to include "<input type=\"text\" value=\"2011-02-28\" name=\"product[released_at]\" id=\"product_released_at\" />".

  2) Failure:
ActionViewTest#test_text_field_with_time_attribute [/Users/danielpk/Code/i18n_alchemy/test/action_view_test.rb:40]:
Expected ["<input id=\"product_last_sale_at\" name=\"product[last_sale_at]\" type=\"text\" value=\"28/02/2011 13:25:30\" />", "<input type=\"text\" value=\"28/02/2011 13:25:30\" name=\"product[last_sale_at]\" id=\"product_last_sale_at\" />"] to include "<input type=\"text\" value=\"2011-02-28 13:25:30 -0300\" name=\"product[last_sale_at]\" id=\"product_last_sale_at\" />".

  3) Failure:
ActionViewTest#test_text_field_with_decimal_attribute [/Users/danielpk/Code/i18n_alchemy/test/action_view_test.rb:32]:
Expected ["<input id=\"product_price\" name=\"product[price]\" type=\"text\" value=\"1,99\" />", "<input type=\"text\" value=\"1,99\" name=\"product[price]\" id=\"product_price\" />"] to include "<input type=\"text\" value=\"1.99\" name=\"product[price]\" id=\"product_price\" />".
carlosantoniodasilva commented 9 years ago

Fixed by #38, let us know if you're still seeing any issue. Thanks!

carlosantoniodasilva commented 9 years ago

Just released v0.2.2.