search

carloscinelli / benford.analysis

Tools that make it easier to use Benford’s law for data validation and forensic analytics.
61 stars 15 forks source link

refactor plot functions #23

Closed rafaelslins closed 5 years ago

carloscinelli commented 5 years ago

Hi Rafael double check the code for the plots, this version will reintroduce the par() side-effect, the code should be as in the current version with:

old.par <- par(no.readonly = TRUE) on.exit(par(old.par))

Inside the Multiple if().

carloscinelli commented 5 years ago

Make sure the fork is up to date with the current version before submitting the pull request. Also, it seems there is a warning in the check, it is a mismatch between the usage In the help file and the default in the function. To fix that, remove the “usage” part right above the function and then Roxygen will automatically create the correct usage in the help file when you rebuild the package.