carloscinelli / benford.analysis

Tools that make it easier to use Benford’s law for data validation and forensic analytics.
61 stars 15 forks source link

KS test significance level and p-values #29

Open carloscinelli opened 5 years ago

carloscinelli commented 5 years ago

@rafaelslins the current critical value for the KS-test seems to be hard coded for the significance level of 5%.

For now, this should be informed in the output of the test, since the significance level is hard coded.

But as an improvement, we should either provide other significance levels as an option, or, instead, provide the p-value of the KS-test (we can use a ks critical value table to get the approximate p-value).

Another alternative is using the base R ks.test function, but we need to double check whether it works well.