search

carloscinelli / sensemakr

Suite of sensitivity analysis tools for OLS
https://carloscinelli.com/sensemakr/
83 stars 15 forks source link

worstcaseplot defaults #13

Closed chadhazlett closed 6 years ago

chadhazlett commented 6 years ago

worstcaseplot, if called directly, fails when no default limit is given:

worstcaseplot(sense.out) Error in seq.default(0, lim, by = 0.001) : 'to' cannot be NA, NaN or infinite In addition: Warning message: In max(r2d, na.rm = TRUE) : no non-missing arguments to max; returning -Inf

statsccpr commented 6 years ago

temporary fix is to not export the specific plot methods

neither worstcaseplot() nor contourplot()

as in the commit below

https://github.com/chadhazlett/sensemakr/commit/fe03bfa553944104e62fad3e699cc91fd6752710

chadhazlett commented 6 years ago

Yes; I've already committed this change.

On Mon, Aug 14, 2017 at 1:55 PM, statsccpr notifications@github.com wrote:

temporary fix is to not export the specific plot methods

neither worstcaseplot() nor contourplot()

fe03bfa https://github.com/chadhazlett/sensemakr/commit/fe03bfa553944104e62fad3e699cc91fd6752710

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chadhazlett/sensemakr/issues/13#issuecomment-322307032, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVCyBxq_V2kGk57IIACcwoTj4YqM6rmks5sYLQugaJpZM4O1RAH .

statsccpr commented 6 years ago

confirmed, pulled the new changes