Closed chadhazlett closed 5 years ago
im thinking an immediate thing to do is keep the current label positions, add an optional null argument to turn it off.
then leave it to the user to label the points themselves along the lines of
https://gist.github.com/slowkow/003b4d9f3f59cee8551c
instead of directly incorporating these extra package dependencies leave it to the user to go the extra step. the wordcloud example seems like an ez extra end-user side customization.
mike
On Sep 16, 2017 6:02 PM, Chad Hazlett notifications@github.com wrote:
We knew this would be an issue, and if we can't solve it right now, okay. But the overlap in the label positions is problematic indeed.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/chadhazlett/sensemakr/issues/26, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQWiuIXF_1tNhRV0IddYp_o7vTGd6i-Kks5sjG-rgaJpZM4PaAB4.
i quickly threw together 3 different methods for post-processing label placements the end-user can pursue
https://github.com/chadhazlett/sensemakr/blob/master/tools/label_coord_custom_ex.R
I think they should not be formally integrated into sensemakr, to keep the package dependencies lightweight. That is, keep these as commented out examples in the documentation of plot, or add a section into the vignette
the maptools method via genetic algorithm and simulated annealing does pretty good
Added 'End-User Label Placements' section to vignette
Thanks Michael. My sense is we should go with this approach for now and to get this thing moving. In the next version we can consider bringing this inside the package, with a "suggests" dependency.
On Mon, Sep 18, 2017 at 4:15 PM, statsccpr notifications@github.com wrote:
Added 'End-User Label Placements' section to vignette
https://github.com/chadhazlett/sensemakr/blob/ master/vignettes/sensemakr.md#end-user-label-placements
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chadhazlett/sensemakr/issues/26#issuecomment-330382544, or mute the thread https://github.com/notifications/unsubscribe-auth/AFVCyBpd3EAT2yyaQJu842DnCdW1IdUoks5sjvmAgaJpZM4PaAB4 .
We knew this would be an issue, and if we can't solve it right now, okay. But the overlap in the label positions is problematic indeed.