search

carloscuesta / gitmoji-cli

A gitmoji interactive cli tool for using emojis on commits. 💻
https://www.npmjs.com/package/gitmoji-cli
MIT License
4.58k stars 206 forks source link

support `git commit` options within `gitmoji -c` #1040

Open AndreasAugustin opened 1 year ago

AndreasAugustin commented 1 year ago

Description of the problem

$ gitmoji -v
8.0.0

Currently it is not possible to use git commit flags and options when calling gitmoji -c.

Because of that some super useful options like git commit -S to sign the commits is not possible to be used within that command.

Solution

add the needed flags as optional parameters to the already supported flags.

Alternatives

Currently it is possible to add some of the flags to the git global settings. E.g. with the example for -S

git config --global commit.gpgsign true

Furthermore (fast reading the code) I think it should be possible to have this functionality using the --hook flag. gitmoji --hook -S -m .... Need to verify.

This is possible but somehow not nice

Additional context

For me in special the -S option is needed and useful. In many projects I want and need to sign commits and should be considered as best practice. For more information please consider https://dev.to/andreasaugustin/git-how-and-why-to-sign-commits-35dn

There are many more useful options which are currently suppressed. Happy to discuss.

Validations

carloscuesta commented 1 year ago

Hey!

Thanks for opening an issue, completely agree, we should support all the same options that git accepts as a parameter without having to parse them on the cli. Any unknown option should be forwarded to the git binary.

Perhaps we can fix that by using allowUnknownFlags and passing those to git

https://github.com/sindresorhus/meow

Do you want to raise a pull-request?

AndreasAugustin commented 1 year ago

Hey!

Thanks for opening an issue, completely agree, we should support all the same options that git accepts as a parameter without having to parse them on the cli. Any unknown option should be forwarded to the git binary.

Perhaps we can fix that by using allowUnknownFlags and passing those to git

https://github.com/sindresorhus/meow

Do you want to raise a pull-request?

Yes, I can raise a PR. Just cannot promise an ETA. Think I will be at least quite busy the next days (but it shouldn't be a huge change)

carloscuesta commented 1 year ago

Sounds awesome! I'll assign this to you, feel free to take the time you need ❤️