Regarding of Windows' hook issue

tsanyqudsi commented 8 months ago

Describe the bug

in Windows, there's a problem when using gitmoji-cli hooks as explained in https://github.com/carloscuesta/gitmoji-cli/issues/93.

Most probably it has nothing to do with gitmoji-cli but it has something to do with git bash.

When I'm using VSCode, using gitmoji -c will switch the pwsh terminal to node terminal

But when I use the hook, it will switch to git terminal instead

Reproduction

Use gitmoji hook in VSCode

System Info

System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 AMD Ryzen 5 3600 6-Core Processor
    Memory: 6.65 GB / 15.93 GB
  Binaries:
    Node: 20.9.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (120.0.2210.91)
    Internet Explorer: 11.0.22621.1

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

tsanyqudsi commented 8 months ago

@carloscuesta could you put a warning in the readme file for this ?

carloscuesta commented 8 months ago

Hey!

Not sure 100% how VSCode renders that text, but to me looks like the text you refer as "terminal" is the name of the current active process, therefore it is correct that when you commit through gitmoji-cli it is displayed as node since we use a node process underneath.

Definitely not a bug

carloscuesta / gitmoji-cli