gitmoji -c throws ERR_MODULE_NOT_FOUND

enorfelt commented 3 months ago

Describe the bug

When issuing gitmoji -c bellow error is thrown:

node:internal/modules/esm/resolve:265 throw new ERR_MODULE_NOT_FOUND( ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'C:\Users\some.user\AppData\Roaming\nvm\v20.15.0\node_modules\gitmoji-cli\node_modules\inquirer\lib\prompts\base.js' imported from C:\Users\some.user\AppData\Roaming\nvm\v20.15.0\node_modules\gitmoji-cli\node_modules\inquirer-autocomplete-prompt\index.js at finalizeResolution (node:internal/modules/esm/resolve:265:11) at moduleResolve (node:internal/modules/esm/resolve:933:10) at defaultResolve (node:internal/modules/esm/resolve:1157:11) at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12) at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25) at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38) at ModuleWrap. (node:internal/modules/esm/module_job:87:39) at link (node:internal/modules/esm/module_job:86:36) { code: 'ERR_MODULE_NOT_FOUND', url: 'file:///C:/Users/some.user/AppData/Roaming/nvm/v20.15.0/node_modules/gitmoji-cli/node_modules/inquirer/lib/prompts/base.js' }

Node.js v20.15.0

Reproduction

Open up a windows terminal using PowerShell Core
npm i -g gitmoji-cli
Restared windows terminal
do: gitmoji -c

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
    Memory: 12.32 GB / 31.72 GB
  Binaries:
    Node: 20.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (126.0.2592.81)
    Internet Explorer: 11.0.19041.4355

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

segersniels commented 3 months ago

Can reproduce, seems likely that a dependabot bump broke one of our packages. Will investigate.

EDIT: Seems like inquirer unified their monorepo setup and changed from a lib directory to src which is causing inquirer-autocomplete-prompt to fail since it has a peer dependency on an older version of inquirer. Package managers are bumping the version to 9.3.x due to us having ^9.2.23.

segersniels commented 3 months ago

I made a PR to limit to minor versions of inquirer for now @carloscuesta

https://github.com/carloscuesta/gitmoji-cli/pull/1322

EDIT: Merged, awaiting release.

carloscuesta commented 3 months ago

Released thanks everyone! ❤️

enorfelt commented 3 months ago

And it works! Thanks for the quick fix @segersniels and @carloscuesta ❤

carloscuesta / gitmoji-cli