search

carloscuesta / gitmoji-cli

A gitmoji interactive cli tool for using emojis on commits. 💻
https://www.npmjs.com/package/gitmoji-cli
MIT License
4.59k stars 206 forks source link

ctrl-c skip gitmoji prompts stopped working in 3.0.1 #266

Closed eli-symbolab closed 4 years ago

eli-symbolab commented 4 years ago

Hello @carloscuesta!

hi! Thank you for this cool and useful program. I installed the latest 3.0.1 and noticed that the previous behavior of pressing ctrl-c to skip the gitmoji prompt has stopped working. Rolling back to 3.0.0 restored the behavior.

Issue:

Perform a git merge as usual Run git commit, when a gitmoji-cli hook has been installed The gitmoji prompt appears. Press ctrl-c Expected: skipping gitmoji, I see the standard Merge message pre-filled in my git commit message editor. Saving and exiting completes the merge. Actual behavior: gitmoji-cli quits, and the commit is canceled.

OS: macOS Mojave 10.14.6 gitmoji-cli -v: 3.0.1 Node version: 6.13.4

carloscuesta commented 4 years ago

That should have been caused for one of the dependencies we bumped on 3.0.1

eli-symbolab commented 4 years ago

This behavior is reproducible in 3.1.0 as well.

tadejs commented 4 years ago

I confirm on 3.1.0 on Ubuntu 18.04 as well. I was relying on this behavior to make git commit --amend work without needing to retype the commit message. Is there any "official" way to skip the dialogue on commit?

eli-symbolab commented 4 years ago

Same behavior in 3.2.0.

Tydax commented 4 years ago

At first I thought it was a new feature rather than a bug that I was about to ask about because I find it annoying for amending commits and rebasing 😅 . Thank you for reporting this.

Same behaviour in 3.2.1.

carloscuesta commented 4 years ago

As I pointed out this should be the reason for the problem: https://github.com/carloscuesta/gitmoji-cli/issues/266#issuecomment-568406983 if anyone is willing to take a look I would really appreciate it! 🙏

https://github.com/carloscuesta/gitmoji-cli/compare/v3.0.0...3.0.1

Maybe related with https://github.com/sindresorhus/ora/releases/tag/v4.0.2 ?

eli-symbolab commented 4 years ago

Thank you all!!!!!