Closed vhoyer closed 2 years ago
Hey!
So far we've got a suggestion with the new issue template: https://github.com/carloscuesta/gitmoji/issues/1119 and it was a decent improvement over the last format where the user was able to write anything.
The validation really helps here 😂
If you still think we can improve it feel free to raise a PR updating the issue template 🙌🏼
@vhoyer I definitely want it 😉 Please open a PR 🚀
Hey @vhoyer do you want to follow up on this? 👀
I want to, I didn't have the mental band width to tackle this issue yet, tho
If you really want to close the issue I don't mind, I think I will remember that I want to do this, even without it haha
It's fine! Will keep it open 😊
Thanks 🙏🏼
Discussion
I think we should rephrase the
does your commit fall into the "how" category
, because I've seem a lot of confusion about it. Maybe we can even transform it into a checkbox like ones like "- [ ] this emoji describes what is in the commit, and not how it was made", and have a validation that doesn't let people proceed with the issue creation otherwise, then keep the current description just as an info on why this is a requirement.Validations