carloscuesta / gitmoji

An emoji guide for your commit messages. ๐Ÿ˜œ
https://gitmoji.dev
MIT License
15.63k stars 799 forks source link

Which gitmoji should I use for internal API changes? #1523

Closed Thanyanit-J closed 12 months ago

Thanyanit-J commented 1 year ago

Discussion

such as changing frontend REST request format when the backend API changes, changes in private API used within organization, etc.

I know that this ๐Ÿ‘ฝ is for "external API," but what about the internal?

Thank you for suggestion ๐Ÿ’›๐Ÿงก

Validations

vhoyer commented 1 year ago

Personally, if it happened in a different repository, I treat it as a "external API change", if it happened in the same repository, I try to add both modifications as one commit, since I like to always try to have every commit I have in a repository a working version of the code, if the code doesn't work in a given commit, it shouldn't be considered an complete commit.

I'm pretty sure that's why we don't have a "internal API changes"

rafalkrupinski commented 1 year ago

yep, it shouldn't matter if the other project is the same company. It's a different project so it's an external change.

Code-With-Abhishek-Kumar commented 1 year ago

Screenshot at 2023-09-21 15-24-38

Help me to solve this

*** Only Some emoji are working Properly When I commit using gitemoji and push or my gitub then emoji can't show also

rafalkrupinski commented 1 year ago

@Thanyanit-J if your question is answered, please close the issue @CoderAbhi-github off-topic. You have a problem with your environment.