carloscuesta / gitmoji

An emoji guide for your commit messages. 😜
https://gitmoji.dev
MIT License
15.61k stars 799 forks source link

🐉 for Commit blindly #1535

Closed agea closed 1 year ago

agea commented 1 year ago

Emoji symbol

🐉

Emoji code

:dragon:

Emoji description

Commit blindly

Describe the use case of your emoji

You have to commit (and presumably push) some come without any way to test it in a development enviromnent an you have to push it (and usually go through a CI/CD) and test it directily in a staging/production environment, so there is no way t know if your code really works before the commit

The dragon emoji is a reference to the Saint Seiya charachter Shiryu which has to blind himself to defeat an opponent

https://en.wikipedia.org/wiki/Dragon_Shiry%C5%AB https://www.reddit.com/r/SaintSeiya/comments/fwvdvp/how_many_times_will_shiryu_lose_his_eyesight/

Is this use case covered by an existing emoji?

No ❌

Does this emoji fall into the "how" or the "what" category?

Examples

Any kind of code may end here, as an example, you need to read the server url, but in production your application is behind a proxy:

public String getServerName() {
  String forwarded = getHeader("X-Forwarded-Host");
  if (forwarded != null) {
    return forwarded;
  } else {
    return super.getServerName();
  }
}

Validations

pybride commented 1 year ago

Wouldn't a white cane 🦯 U+1F9AF be more clear?

carloscuesta commented 1 year ago

Hey!

To my eyes the meaning behind this emoji explains how you made a commit (blindly) without being able to test it, instead of why this particular commit was made.

Feel free to reopen,

Thanks

agea commented 1 year ago

Hi, @carloscuesta when you say "Feel free to reopen" you mean "change why->how, and I may consider adding de emoji" or "being a how the emoji will probably never be added"?

Thank you

carloscuesta commented 1 year ago

Hey!

My point of view might be wrong, so feel free to reopen the issue (ask for it/open a new one) if you don't agree with the decision that was made

Thanks!