Gitmoji's name vs code for 💫

carloscuesta / gitmoji

An emoji guide for your commit messages. 😜

https://gitmoji.dev

MIT License

15.54k stars 802 forks source link

Gitmoji's name vs code for 💫 #1581

Closed paduszyk closed 12 months ago

paduszyk commented 12 months ago

Discussion

For the "animation" Gitmoji:

{
  "emoji": "💫",
  "entity": "&#x1f4ab;",
  "code": ":dizzy:",
  "description": "Add or update animations and transitions.",
  "name": "animation",
  "semver": "patch"
},

there is an inconsitency in its name and code. For the remaining Gitmojis, the name is simply the code with the underscores replaced by dashes and the leading and trailing colons removed.

Is there any specific reason for which this rule is violated for 💫?

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue requesting the same feature.

carloscuesta commented 12 months ago

Hey!

I don't recall any reason for it to be different 😅. The name of the emoji should be the same as the code but without the semicolons, so let's change it back to name: dizzy.

Thanks for finding this, do you want to open a Pull-Request?

paduszyk commented 12 months ago

OK. I will open the PR ASAP. How would you classify that change? I believe the options are: ♻️, 🚚.

Anyways, maybe you should consider to discard the name field at all? Since it looks like being deterministic...

carloscuesta commented 12 months ago

OK. I will open the PR ASAP. How would you classify that change? I believe the options are: ♻️, 🚚.

:pencil2: Also works!

Anyways, maybe you should consider to discard the name field at all? Since it looks like being deterministic...

Not sure, some external dependencies, services might be using that field, for now I would focus on fixing this specific issue and we can reevaluate in the future if the name field makes sense at the JSON level.