The codepoints of 📦️ seems not correct?

loerise commented 9 months ago

Describe the bug

As emojipedia said, The codepoints of 📦️ should be U+1F4E6, but the codepoints of 📦️ in gitmojis is U+1F4E6U+FE0F.

When I use commitlint-config-gitmoji to lint my commit and use this emoji, it will report a error:

📦 is not in the correct gitmoji list, please check the emoji code on https://gitmoji.dev/. [start-with-gitmoji]

Reproduction

📦️ is copied from https://gitmoji.dev 📦 is copied from https://emojipedia.org/package

Open the Chrome DevTools, type "📦️" === "📦" in console and the result is false. Or search on https://codepoints.net/

System Info

System:
  OS: macOS 13.4
  CPU: (8) arm64 Apple M1
  Memory: 188.17 MB / 16.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.13.0 - ~/.nvs/default/bin/node
  Yarn: 3.5.0 - ~/.nvs/default/bin/yarn
  npm: 9.5.0 - ~/.nvs/default/bin/npm
  pnpm: 8.9.2 - ~/Library/pnpm/pnpm
  Watchman: 2023.09.04.00 - /opt/homebrew/bin/watchman
Browsers:
  Chrome: 118.0.5993.117
  Safari: 16.5

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

vhoyer commented 9 months ago

yeah, well, the codepoint in emojipedia is shorter, so I guess it's wise that we'd prefer this one, I vote we change, but I'm also not completely aware of what are the impacts of changing this

connorjs commented 9 months ago

I use Rocket app for Mac and :package (📦) gives me emojipedia version. This matches the Mac’s built-in emoji picker (CTRL+CMD+SPACE). I do not use CLI tools or assisted, so I’ve always been using this one (I type it myself with Rocket).

I also vote for changing (assuming I understood the issue correctly), but maybe tools like commitlint-config-gitmoji need to allow both.

carloscuesta commented 9 months ago

Sounds reasonable to me, let's change it! 🙏🏼

Feel free to open a PR 🖖🏼

carloscuesta / gitmoji