carloscuesta / gitmoji

An emoji guide for your commit messages. 😜
https://gitmoji.dev
MIT License
15.44k stars 808 forks source link

⚙️ for repo configuration changes (e.g. issue/PR templates) #1724

Open jwflory opened 2 months ago

jwflory commented 2 months ago

Emoji symbol

⚙️

Emoji code

:gear:

Emoji description

Changes to repository meta configuration (i.e. repo settings)

Describe the use case of your emoji

Many of my commits these days are around things that help maintainers manage their repositories better, such as issue and pull request templates. Sometimes these change over time and it is useful to call them out differently than other documentation changes that might be user- or community-facing.

The current gitmoji could possibly group this as 📝 docs, but I think my idea is covers a similar yet distinct stream of contributions that make configuration changes to the workings of the git repository used by the project. This is also distinct from 🔧 for config changes, because to me, that means app configs to me in a repository, not meta repo contribution config changes.

Is this use case covered by an existing emoji?

No ❌

Does this emoji fall into the "how" or the "what" category?

Examples

Validations

vhoyer commented 2 months ago

I donno if I'd be inclined to green light this addition, but if we endup going forward with this, I don't really like the use of :gear: to represent this... although I also don't have an idea of what emoji we could substitute this with.

that said, I think we've created the :technologist: to begin with, and I don't see why this wouldn't be good enough, what do you think about it?

wolfspyre commented 2 months ago

I like the gear icon, as the technologist emoji doesn't work in a lot of contexts, and I agree it's on-brand-ish with the wrench and hammer... and it does reference a specific slice of infra scaffolding which does feel kinda poorly matched by either the wrench or the hammer. ;)

much like the perpetual question of

where do we put the sporks

I can see the benefit of this...

I dunno I'd go with a greenlight for this tho...

there's always: 🪠

:)

wolfspyre commented 2 months ago

I dunno I'd go with a greenlight for this tho...

there's always: 🪠

:)

I'd misunderstood your comment and thought you were suggesting using a green traffic light as a visual representation ... not greelight as in 'approve' ;)

What would you see the gear icon being applicable to?

pipeline/project/repo componentry does feel aligned with it... ¯\_(ツ)_/¯

vhoyer commented 2 months ago

well, to be fair, I think that the gear emoji would actually feel more in place with the "config file" commit and we'd swap those emojis around, but I don't think that's a viable option due to the "breaking change" it would pose to the standard.

also, sorry for the confusing term I used, I really should watch my usage of them more.

the thing is, I'm a strong believer in trying to prevent the addition of new emojis as often as I can, because more only increase maintenance cost and post as a barrier of entry for new comers to gitmoji (like, it's daunting to see a big tall wall of emojis if you just wanna commit in a repo ta uses gitmoji), so I always try to resist addition of emojis, and in this case I see too much overlap with the technologist emoji to justify the addition.

you could argue that the emoji for the technologist is not a good one, and I'd agree, but I'm always in favor of broadening the meaning of an already present emoji then adding a new emoji, and that's my reasoning.

do you don't think that the technologist is a good enough category for those kinds of configurations? what would change your minds over this?

cruzdanilo commented 2 months ago

i don't think this use case is distinct enough from "🔧 add or update configuration files".