carloscuesta / gitmoji

An emoji guide for your commit messages. 😜
https://gitmoji.dev
MIT License
15.62k stars 799 forks source link

✨ Enhancement: Add 🌌 for whitespace commits #548

Closed jeremysawesome closed 4 years ago

jeremysawesome commented 4 years ago

Hello @carloscuesta :sunglasses:!

I hope you are having a superbly amazing day.

I was thinking 🌌 because it also is referred to as "space". However, πŸ‘Ύ could work since it's "github" name is "space_invader" πŸ€”

I'll go ahead and put in a PR for 🌌

Additional Reasoning: There are times when you want to change the whitespace in a file. Whether that's adding new lines, removing lines, adjusting leading space, etc... However, those kinds of whitespace changes can add to unnecessary churn in a codebase and it can lead to annoying reviews. That's why adding a whitespace only commit can be helpful. It helps communicate to teammates the intent of the commit.

johannchopin commented 4 years ago

I guess 🎨 :art: (Improve structure / format of the code.) fulfill this case.

carloscuesta commented 4 years ago

Hey @jeremysawesome I also think this is also covered by :art: and since this is already covered on the spec there’s no need to introduce it as a new gitmoji!

Thanks for your suggestion!

jeremysawesome commented 4 years ago

Alright then, bummer.

Thanks for the feedback πŸ‘

carloscuesta commented 4 years ago

For sure you can keep using this Gitmoji if it makes sense to you! This is what is all about 😍