carloscuesta / gitmoji

An emoji guide for your commit messages. ๐Ÿ˜œ
https://gitmoji.dev
MIT License
15.63k stars 799 forks source link

๐Ÿ•ต๏ธ for changes to enhance observability #725

Open sylvanaar opened 3 years ago

sylvanaar commented 3 years ago

Hello @carloscuesta :sunglasses:!

This generalizes the Health Check (#668) proposal to mean any code that enhances the observability of the code. This includes instrumentation for debugging or adding metric sources, logs(covered?), and tracers.

Anything that helps you to find problems, and explores their root cause - but is not the main purpose of the rest of the application.

I liked the magnifier, and I pointed it to the right - but it is the same emoji as SEO. So I found this one.

vhoyer commented 3 years ago

Personally I prefer the generic approach, but the description is kinda... lacking? Could you propose a better name for it?

sylvanaar commented 3 years ago

@vhoyer - the best name is observability - but that may not be a term everyone knows.

Description: "Improve observability", in line with "Improve accessibility"

Here is some background on observability

Here's an excerpt:

observability is how you explain unknown-unknowns, that itโ€™s about exploration and debugging instead of dashboards and pattern matching or accessing certain data type

vhoyer commented 3 years ago

Donno, @carloscuesta @johannchopin , any thoughts?

johannchopin commented 3 years ago

I like it since it can cover the analytic Gitmoji ๐Ÿ“ˆ and also cover all other runtime debugging tool like sentry for example ๐Ÿ‘

vhoyer commented 3 years ago

Does this really cover analytics?

carloscuesta commented 3 years ago

I don't see the use cases clear for this emoji, could you provide some examples?

sylvanaar commented 3 years ago

Hi @vhoyer, yes, it covers the collection of analytics.

@carloscuesta - this covers:

Observability is your UI for servicing/operating your application.

The emoji itself might be worth resisting - I want it to express "seeing inside" something.

As a more generic concept, it is a superset that contains ๐Ÿ”Š (๐Ÿ”‡?) ๐Ÿฅ… (if they are exposed) ๐Ÿ“ˆ

So quite a lot of this concept is not yet covered.

vhoyer commented 3 years ago

You know what? I like it. Tho it could be hard to covey this idea merely by "observability" ๐Ÿค” albeit I have no better suggestion...

connorjs commented 3 years ago

Was just scrolling through the issues. +1 to the generic nature. Does "enhance insight" offer an alternative term? (From the thread, it seemed the term "observability" gave some pause, and I immediately thought "insight" when reading through.)

meg-gutshall commented 3 years ago

@sylvanaar, if you want to hold out for a different emoji, X-Ray is a candidate for Unicode 14.0. It'll be a bit of a wait though.

vhoyer commented 3 years ago

how about "improve code inspection"? @carloscuesta @johannchopin

johannchopin commented 3 years ago

@vhoyer Yep I would agree on that ๐Ÿ‘Œ

carloscuesta commented 2 years ago

Hey!

The problem is see with this proposal is that we already have:

Logs:

Healthchecks:

This one feels like grouping all of them into a bigger category, does it makes sense to add an emoji that covers all of the use-cases while maintaining those 3? ๐Ÿค”

vhoyer commented 2 years ago

well, a lot of things are a grouping of the โœจ and ๐Ÿ› already, right? (in fact, it would be cool to see a visualization of this categories ahah)

connorjs commented 2 years ago

FWIW, since my original comment, I have seen and heard more references to the term observability. To provide another industry reference, I found a Google dev ops article on observability (and monitoring).

Some more thoughts about choosing the gitmoji for commits following some recent work I have done. Overall, happy enough with the landscape, but feel that we could improve wording around this area. Plus, holding out for xray could have benefits (I find not using person emojis better).

  1. ๐Ÿ”Š and ๐Ÿ”‡ explicitly say logs. To me, this excludes metrics, because I have always explicitly used the terms metrics and logs separately. However,
    1. I wonder if others do not view the same exclusion.
    2. If others do, or maybe just for search optimization, we could extend the definitions to include logs and metrics or logs and monitors or some other variation
  2. After scrolling through all gitmojis twice (minus speaker ones, above), I settled on ๐Ÿฉบ for health check. However,
    1. I noticed it says add or update. Any historical commentary on no remove here? (Guessing just historical and speakers were older items in โ€œspecโ€)
    2. This worked for my tasks (adding performance or status related metrics), but unsure if it applies to A/B testing metrics. (But maybe ๐Ÿ“ˆ, analytics or track code covers this?)
carloscuesta commented 2 years ago

Hey! Sounds good to me let's add this one ๐Ÿ™๐Ÿผ

connorjs commented 2 years ago

Nice! Let me re-ask one of my questions hidden in my musings ๐Ÿ˜…

Do the speaker/sound gitmojis (๐Ÿ”Š and ๐Ÿ”‡) refer explicitly to logs (and not metrics)? Or - no - they can also include metrics.

carloscuesta commented 2 years ago

I would say speaker/sound gitmojis only refer to logs!

connorjs commented 2 years ago

Thanks for clarifying!

@sylvanaar - Do you have any new thoughts to add here? And thoughts on holding out for XRay emoji?

(I really like using XRay as @meg-gutshall mentioned. And we should hopefully see it coming soon.)

julealgon commented 1 year ago

Not a big fan of introducing something that becomes a higher category for existing categories. The fact that this would cover both logs and metrics/tracing, which I already use the existing icons for, would just cause ambiguity IMHO.

If there is some area of observability that is not covered today, I'd rather a specific icon be introduced for that instead of creating an "umbrella" icon that makes existing ones "obsolete".

connorjs commented 1 year ago

@jlandure - which emojis/icons do you use for metrics and/or tracing? My main interest was finding the best one for metrics, but tracing definitely relates.

connorjs commented 1 year ago

Regarding "observability as a higher category" - I am considering including an "observability" tag in #924 if we think observability does represent a higher grouping of existing emojis, and we would prefer a new, specific emoji.

Tentatively, I have this list.

Thus, I think โ€œmetricsโ€ is still missing, and I think we should have a dedicated emoji for it instead of trying to bind it to one of the existing ones. I will think about some emoji choices...

(Note: I prefer not to use people emojis because of skin color configuration. For example, I use rocket to insert my emojis, so using detective inserts as ๐Ÿ•ต๐Ÿปโ€โ™‚๏ธ by default for me. Related article I think this one).


Note: I originally included ๐Ÿง Data exploration/inspection, but after reading #615, I think it no longer applies.

connorjs commented 1 year ago

Oh, and on the subject of tracing.

Does ๐Ÿ“ˆ (Add or update analytics or track code) represent tracing? See #36 for original issue.

If not, I think we hold out for ๐Ÿฉป(x-ray) support. (Slack uses :x-ray: and Discord uses :x_ray:, so we would wait for GitHub/GitLab support.)

connorjs commented 1 year ago

My candidates for โ€œAdd, update, or remove metrics,โ€ sorted alphabetically by short code.

Emoji Short code Reason Link
๐Ÿ”ข :1234: Metrics are numeric (in value) Emojipedia
๐Ÿงฎ :abacus: Counts are common metrics; emoji can be used for numbers in general Emojipedia
๐Ÿ“Š :bar_chart: Metrics are charted/plotted/graphed, and ๐Ÿ“ˆ already taken Emojipedia
โฑ๏ธ :stopwatch: Timing is a very common metric Emojipedia
๐Ÿ“ :straight_ruler: Ruler for measuring Emojipedia
๐Ÿ“ :triangular_ruler: The other ruler, but โ€œmore engineering-y.โ€ Emojipedia
vhoyer commented 1 year ago

ok, so, what is the definition of "tracing" and "metrics" we are working here? (because I always used :mute: and :loud_sound: for "tracing" and :chart_with_upwards_trend: for "metrics")