carloscuesta / gitmoji

An emoji guide for your commit messages. 😜
https://gitmoji.dev
MIT License
15.54k stars 802 forks source link

Introduce the shibui gitmoji (beautiful and simple) #930

Closed EmGarr closed 2 years ago

EmGarr commented 2 years ago

Hello @carloscuesta :sunglasses:!

vhoyer commented 2 years ago

Firstly, I loved the idea as an idea, because I'm obsessed with Japanese culture (in fact, I was listening to my Spotify Wrapped while writing this comment, and most of the songs are in japanese), but because I liked it so much, I feel the need to be specially impartial; I've always adopted the position of trying my best not to add more emojis to the "spec" to prevent useless complexity for newcomers to gitmoji (since I've encountered resistance amongst my peers about the adoption of gitmoji due to "there being too many emojis, I always feel confused about which one to use"). Stick with me in this haha:

So here are my concerns/inquires:

EmGarr commented 2 years ago

Thanks for the answers :heart: .

I clearly here your concerns and shibui is clearly a "how" and not a "what". I mostly used it when I find a solution to a complex problem with a really simple solution. It is just a mark of proudness I guess :laughing: .

Regarding the description I guess: simple and beautiful only would fit the shibui spirit.

For the emoji I really like :diamond_shape_with_a_dot_inside: but after reflection I also thought of :snowflake: (simple and beautiful).

I guess shibui is not a concept mainstream enough to add it in gitmoji. However, I found that this way of thinking for designing code is most of the time one of the most powerful.

Since it is mostly a how and not what I guess we can close the issue. However, I actually loved that you loved the idea as an idea :+1:

carloscuesta commented 2 years ago

Hey! I think that @vhoyer explained very well the criteria we use when trying to add new emojis!

You can still use the emoji for the project, at the end of the day this is just an idea that people can transform embrace and adapt based on their needs

Thankd for opening the issue! 😊

vhoyer commented 2 years ago

oh yeah, the :snowflake: would be very cool for this, but either way thank for opening the issue :D

vhoyer commented 2 years ago

@carloscuesta, do you think we could add this notion of "what"/"how" to the contribution guide or in the issue template?

carloscuesta commented 2 years ago

Yes please! It would be a great addition