Closed lsagetlethias closed 2 years ago
Hey @lsagetlethias thanks for opening an issue!
We discussed this emoji before in https://github.com/carloscuesta/gitmoji/issues/348 it was part of the convention but it was removed.
If you think a bit deeper about it when someone requests a code review, it is because there's an issue or a potential improvement, that change can be categorized using one of the existing emojis.
Using your examples:
:handshake: Handle review from @user :handshake: Apply review from @user
This example falls into the "how" category.
:handshake: Change logic as suggested
This one should be covered with 👔 or a fixup of the previous commit where the logic was introduced.
You'll find more discussion on the thread I linked.
Thanks!
Seems fair! Thank you for the ref.
Hello @carloscuesta :sunglasses:!
:handshake:
Describe the use case of your emoji
When working in team, gives a way to mark code part of a review resolution and avoid micro atomic commits.
Is this use case covered by an existing emoji?
Yes, with 🐛 but not entirely ; or yes if we allow micro commits in our repo or if we don't care about reviews commits.
Does this emoji fall into the "how" category?
I don't think so.
Examples
:handshake: Handle review from @user
:handshake: Apply review from @user
:handshake: Change logic as suggested