carlosdcastillo / vim-mode

Experimental next generation vim support for atom. This project needs a new home!
557 stars 18 forks source link

Atom not displaying changes #4

Open alvaromartinlop opened 9 years ago

alvaromartinlop commented 9 years ago

Hi, I am trying to use your plugin with

Neovim 0.0.0-alpha+201501260219 (compiled Jan 26 2015 11:21:06) Atom 0.176.0

My version uses master HEAD from Jan 26, which has the branch abstract-ui-fixes merged.

When I run atom, neovim listens to changes from atom, but atom doesn't show back any of the changes.

I am sending you a gif with Atom on the left and neovim on the right, so you can see the problem. All the text input is done in the atom window.

vim-mode

carlosdcastillo commented 9 years ago

@alvaromartinlop how are you invoking neovim? Make sure you invoke like this:

NVIM_LISTEN_ADDRESS=/path/to/socket ./nvim -T abstract_ui

the fact that you're showing a visible session of neovim seems problematic.

It could also be that what was merged differs slightly to the version in @tarruda's tree I've ben testing against, try against the one in the readme.

Also, if you get it to update the atom window I think you may need to scale back your neovim config for it to work -- the code doesn't handle autocomplete or the like.

alvaromartinlop commented 9 years ago

I wasn't using -T abstract_ui. But I tried and I had no luck.

Then I tried installing neovim using the commit hash mentioned in your documentation and there was progress. Now I get a "partial vim window" with double number columns and it updates the atom window.

image

You were right. I have to scale down my neovim config. Autocomplete messes things up.

Also, the reason why I thought it would work with the latest vim is because someone said it would in reddit.

http://www.reddit.com/r/neovim/comments/2sq1dz/current_status_of_guis_for_neovim/

fwalch commented 9 years ago

Never trust random people on the internet ;-) But seriously, I only said that it should work; after all, abstract_ui has been merged. Apparently I was wrong, sorry.

carlosdcastillo commented 9 years ago

@alvaromartinlop You can eliminate the double line count by setting DEBUG to false in line 13.

I think the sequence of calls for abstract ui was tweaked before landing in the main neovim repository. I will try to track down the difference.

alvaromartinlop commented 9 years ago

@fwalch no worries, your reddit comment made me install the plugin :). @carlosdcastillo Thanks, i'll turn DEBUG to false, and try to make it work for more than 17 lines.

trusktr commented 9 years ago

I think I'm having this same problem. I'm running neovim like this:

NVIM_LISTEN_ADDRESS=/tmp/neovim/neovim581 nvim -T abstract_ui

and not only do I not see the results, but scrolling also causes text to be rendered in random places. Can't wait for it to be stable. xD

I'm on the latest master branches of neovim and vim-mode as of this writing.

carlosdcastillo commented 9 years ago

@trusktr Can you post a screen shot?

trusktr commented 9 years ago

@carlosdcastillo Here's a video: http://youtu.be/M8g-K5RfjcE

trusktr commented 9 years ago

By the way, is it possible to make neovim start without it rendering it's terminal UI?

carlosdcastillo commented 9 years ago

Try opening some existing file in Atom with Cmd-O.

carlosdcastillo commented 9 years ago

I don't think there is a way anymore. The original patches for abstract-ui did not show the UI, but eventually it got to a point where they started showing it.

trusktr commented 9 years ago

I tried opening a file, and it looks nice at first, but then scrolling and messing with it starts messing it all up in the same way.

carlosdcastillo commented 9 years ago

Let me prepare a video for you. Maybe you have too high expectations or maybe your expectations are reasonable but you have something setup incorrectly. I'm going to generate a video of what you should be able to see.

carlosdcastillo commented 9 years ago

OK. This is the video: https://www.youtube.com/watch?v=7TVBcdONEJo

carlosdcastillo commented 9 years ago

Upon closer inspection to your video it seems:

asivitz commented 9 years ago

@trusktr did you check the Atom console for errors?

tarruda commented 9 years ago

NVIM_LISTEN_ADDRESS=/tmp/neovim/neovim581 nvim -T abstract_ui

The -T option is now a no-op(should be removed). To start a headless nvim instance you need to use the --headless option

trusktr commented 9 years ago

@carlosdcastillo I have a colorscheme applied in nvimrc and a bunch of plugins. I'll try without them and see what happens.

trusktr commented 9 years ago

@carlosdcastillo I can't get it to work right now:

screen shot 2015-03-13 at 9 06 49 pm

EDIT: nevermind, it can connect if I remove /tmp/neovim/neovim581.

trusktr commented 9 years ago

@carlosdcastillo I just tried it with a completely empty nvimrc, running the command

NVIM_LISTEN_ADDRESS=/tmp/neovim/neovim581 nvim --headless

and the same type of glitchiness happens: I start atom and it opens three tabs, I'm unable to switch to the other two tabs, and closing the last tab constantly reopens it. Then if I type a few lines, go to VISUAL line mode, select the few lines (the selection highlight isn't visible), and paste the lines, the result is that not all pasted text is rendered and randomly shows up if I move the cursor around.

In the following video, I start nvim, then I type "let's type a few lines of text" which you can't see as I type (what's that thing you use to show your keystrokes?), press yy, and finally p a few times which pastes the text and you see the glitched result. I pressed p like 5 times, and we see partial results.

http://youtu.be/UHuIrlO8Zgc

asivitz commented 9 years ago

You're trying some complex actions. :) Does the easy stuff work? (Start up, type in file, vi commands)

Lots of things aren't implemented yet. But, it can be fun to pick one of those actions and get it working.

carlosdcastillo commented 9 years ago

In addition to what @asivitz said, two things, I may help if while troubleshooting you don't do --headless so you can see what neovim shows, it should be in sync with what Atom shows. Also it may help if you open a simple C file or a simple Python file (with Cmd-O) and try to edit it a little bit.

carlosdcastillo commented 9 years ago

@trusktr To show the keys I press I use a software called Mousepose.

trusktr commented 9 years ago

@carlosdcastillo @asivitz Sweet, I just found https://github.com/keycastr/keycastr (Open Source FTW!). Let me record a video so you guys can see what keypresses I'm trying.

trusktr commented 9 years ago

Here's a video showing some basic keystrokes, with nvim -u NONE: http://youtu.be/TKG3Ii8nyio

This particular glitch happens after pasting with p.

carlosdcastillo commented 9 years ago

@trusktr The problem with new files is known and will be solved. It will open one tab with filename untitled and when that file does not exists it go ahead and open a tab with filename undefined. A bug in the neovim-mode plugin.

The other is a redraw glitch. When you suspect that is happening hit Ctrl-L.

trusktr commented 9 years ago

Might it be a glitch in neovim causing it to send the wrong data to the client? Or a bug in the client improperly rendering the data?