carlosedp / cluster-monitoring

Cluster monitoring stack for clusters based on Prometheus Operator
MIT License
740 stars 200 forks source link

Update 0prometheus-operator-deployment.yaml #10

Closed castironclay closed 5 years ago

castironclay commented 5 years ago

Add base image. 2/3 pods will fail to start without also specifying the base image.

carlosedp commented 5 years ago

This manifest file is auto-generated by the JSONNET libraries. It's part of https://github.com/coreos/prometheus-operator/blob/master/jsonnet/prometheus-operator/prometheus-operator.libsonnet and the image used to deploy Prometheus by the operator come from: https://github.com/carlosedp/prometheus-operator-ARM/blob/1f50c68326facb6a4d9a443cdce664bd43bc7956/image_sources_versions.jsonnet#L21.

You can check this on the manifest that is auto-generated:

https://github.com/carlosedp/prometheus-operator-ARM/blob/1f50c68326facb6a4d9a443cdce664bd43bc7956/manifests/prometheus-prometheus.yaml#L28

Is this really required?

castironclay commented 5 years ago

Ah I see the mistake. I needed to start using the operator on ARM and I initially cloned and modified the image section of the operator manifest. I deployed via the bundle.yaml file.

I could not find how to change the 3 images needed for the 3 containers until I found your 0prometheus-operator-deployment.yaml file but then noticed you didn't have the base image. After adding my commit to the bundle.yaml I figured yours could use the same line. Missed your other manifest file so not I don't think my commit is needed now. Thanks for the response!

carlosedp commented 5 years ago

The images I built have manifests for both ARM, ARM64 and AMD64 so no changes are needed:

Image: carlosedp/prometheus
 * Manifest List: Yes
 * Supported platforms:
   - linux/arm
   - linux/arm64
   - linux/amd64

In case you want to re-generate the manifests, change the jsonnet files and build the manifests with make. A few pre-reqs are needed though.

castironclay commented 5 years ago

Thank you for the explanations!