search

carlosedp / cluster-monitoring

Cluster monitoring stack for clusters based on Prometheus Operator
MIT License
740 stars 200 forks source link

Fix ingress changes reverting when running make #117

Closed ToMe25 closed 3 years ago

ToMe25 commented 3 years ago

This PR fixes the changes from #111 and #115 being undone when make is run.

This is done by changing utils.libsonnets newIngress method to no longer use ksonnet, since ksonnet doesn't support networking.k8s.io/v1. I don't think this is a perfect way to implement this, but it seems to work reliably and isn't terribly hacky, so it should be fine. Doing this without moving away from ksonnet would require switching to jsonnet-libs/k8s-libsonnet or something similar, which is something I cannot do.

Because this PR also contains the generated manifests it contains a few changes in other manifests, and undoes #105/#108. Fixing the issue from those permanently would require updating whichever software generates those manifests, and that is beyond my capabilities.

If this PR should not undo #105/#108 even tho running make will do that anyways, please let me know. In that case I will manually re add these changes.

carlosedp commented 3 years ago

Thanks!