search

carlosflorencio / laracasts-downloader

Downloads new lessons and series from laracasts if there are updates. Or the whole catalogue.
http://carlosflorencio.github.io/laracasts-downloader
MIT License
685 stars 146 forks source link

Support PHP8 #119

Closed kossa closed 1 year ago

kossa commented 3 years ago

Hello,

Getting some error when using PHP8


====================================
Authenticating
====================================
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182
> Successfull!

====================================
Starting Collecting the data
====================================
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182
mouson commented 3 years ago

symfony dom-crawler 5.2 will fix it.

https://github.com/symfony/dom-crawler/commit/702ee651db23dc452bf1fd6dea6ca2f671ed2681

kossa commented 3 years ago

Currently it uses "2.8.x-dev" https://github.com/carlosflorencio/laracasts-downloader/blob/master/composer.lock#L513

insign commented 1 year ago

Working fine here with PHP 8.2. I recommend close this issue.

carlosflorencio commented 1 year ago

Thanks @insign , closing.