search

carloshenrq / ragnaservice

RESTful api for ragnarok emulators
GNU General Public License v3.0
0 stars 0 forks source link

Removido Alocação de Strings de Tradução #36

Closed carloshenrq closed 5 years ago

carloshenrq commented 5 years ago

Introdução ao Pull Request

Alterações propostas

Quando se usa "STRING DO PHP" , o php acaba sendo um pouco mais lento e consumindo mais memória pois tenta tratar informações como "Seu nome é {$var}." enquanto que se for 'Seu nome é {$var}' a variavel não é tratada.

As aspas duplas foram removidas dos métodos __t que realizam a tradução.

Issues:

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #36   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      159    159           
=======================================
  Files            16     16           
  Lines           654    654           
=======================================
  Hits            654    654
Impacted Files Coverage Δ Complexity Δ
app/App.php 100% <100%> (ø) 49 <0> (ø) :arrow_down:
app/Controller/Profile.php 100% <100%> (ø) 34 <0> (ø) :arrow_down:
app/Controller/ControllerParser.php 100% <100%> (ø) 10 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62ed898...7856e44. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #36   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      159    159           
=======================================
  Files            16     16           
  Lines           654    654           
=======================================
  Hits            654    654
Impacted Files Coverage Δ Complexity Δ
app/App.php 100% <100%> (ø) 49 <0> (ø) :arrow_down:
app/Controller/Profile.php 100% <100%> (ø) 34 <0> (ø) :arrow_down:
app/Controller/ControllerParser.php 100% <100%> (ø) 10 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62ed898...7856e44. Read the comment docs.