Not compatible with leptos v4.0.0 +

[jsprog]

When building in release mode with trunk and leptos@0.4.1 trunk build --release, I'm receiving this error:

the trait leptos::Component<_> is not implemented for fn item fn(leptos_reactive::scope::Scope, IconProps<_>) -> impl leptos_dom::IntoView {leptos_icons::Icon::<_>}

[MinaMatta98]

This is also the case with cargo leptos.

[lpotthast]

This is expected, as only the Component trait from Leptos 0.3 is implemented for the icon component function when you depend on a version of leptos-icons targeting leptos 0.3 and target leptos 0.4 yourself. Different versions of the same type are present when compilation runs leading to this kind of error.

[MinaMatta98]

Is there a version which targets 4.0+?

On Sun, 2 July 2023, 6:52 am Lukas Potthast, @.***> wrote:

This is expected, as only the Component trait from Leptos 0.3 is implemented for the icon component function when you depend on a version of leptos-icons targeting leptos 0.3 and target leptos 0.4 yourself. Different versions of the same type are present when compilation runs leading to this kind of error.

— Reply to this email directly, view it on GitHub https://github.com/Carlosted/leptos-icons/issues/16#issuecomment-1616109844, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATPWGTCNL6W26GO6GL2QMX3XOCEYPANCNFSM6AAAAAAZ2LGD24 . You are receiving this because you authored the thread.Message ID: @.***>

[lpotthast]

Made a PR for it. Until released as leptos-icons 0.0.15, you can already try it out using

leptos-icons = { git = "https://github.com/lpotthast/leptos-icons", branch = "leptos_0.4", features = [
    // ...
] }

[carloskiki]

This is closed by #17

[MinaMatta98]

Thank you 😊

On Mon, 3 July 2023, 3:43 am Charles Edward Gagnon, < @.***> wrote:

Closed #16 https://github.com/Carlosted/leptos-icons/issues/16 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Carlosted/leptos-icons/issues/16#event-9700762051, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATPWGTHSCTULWY7BHLXUZRDXOGXK3ANCNFSM6AAAAAAZ2LGD24 . You are receiving this because you authored the thread.Message ID: @.***>

[jsprog]

FYI: Usually, I don't depend on non release dependencies unless I faced some blockers. Unfortunately, leptos-icons@0.0.15 is broken again with the git dependency of leptos

based on examples/simple-app, replace leptos dependency to # leptos = { git = "https://github.com/leptos-rs/leptos", features = ["csr"] } and build again to receive these errors:

the trait ComponentConstructor<_> is not implemented for &fn(leptos_reactive::scope::Scope, IconProps) -> impl leptos_dom::IntoView {leptos_icons::Icon}

the trait leptos::Component<_> is not implemented for fn item fn(leptos_reactive::scope::Scope, IconProps) -> impl leptos_dom::IntoView {leptos_icons::Icon}