Closed carloskiki closed 9 months ago
Can you explain how you would like licenses to be handled? Should they be scraped automatically from the downloaded icon packages? We should probably add a note to the readme, saying something like:
"Licenses of the icons provided through this libraries were extracted with best intend, but must only be taken as a hint. Please check the individual icon repositories for up-to-date license information."
After looking a bit at other libraries, They either simply state each license in the readme, or they provide a data-attribute
like data-license="MIT"
to every svg. After consideration I think the way we do it currently is fine, I will quickly add the note which is a good idea.
Known Issues
fill
property for every xml tag inside thesvg
. If the overall svg contains two distinctfill
colors, the darker one would be overwritten tocurrentColor
. The lighter color (or the only color if only onefill
color is set) is the one which corresponds to the secondary tone, and could be set with a css variable or kept track of in the library code. This would permit users to manage the color of twotone icons properly.Unanswered Questions: