search

carloskiki / leptos-icons

An icon library for the leptos web framework
MIT License
88 stars 18 forks source link

Update to Leptos 0.6 #41

Closed paul-hansen closed 8 months ago

paul-hansen commented 8 months ago

Just a simple version bump. Example was working for me and was able to use it in my project using these changes.

paul-hansen commented 8 months ago

@Carlosted Looks like you have a test that runs against minimal versions of the library (which is cool, didn't know you could do that) It was failing on the bytes crate being too old and not implementing a trait that was used in leptos' server_fn crate. I added the minimal version of bytes that compiles to the [target.'cfg(any())'.dependencies] section of the Cargo.toml as that looks like how you have fixed other cases of this. I was able to replicate the failure locally using the steps from the github workflow and this seems to fix it. I'm not very familiar with how this works though so feel free to correct me or make changes to this branch as needed. Thanks!

paul-hansen commented 8 months ago

Other CI failures should all be addressed now too :crossed_fingers:

Since Leptos doesn't state an msrv in their Cargo.toml, I just checked each Rust version until I found the next that worked and used that.

carloskiki commented 8 months ago

This is great TY!

I will merge and publish a new version of leptos-icons for leptos v0.6.